Thread (49 messages) 49 messages, 8 authors, 2017-02-02

Re: [PATCH v7 11/12] zsmalloc: page migration support

From: Sergey Senozhatsky <hidden>
Date: 2017-01-23 05:30:43

On (01/23/17 14:22), Minchan Kim wrote:
[..]
quoted
Anyway, I will let you know the situation when it gets more clear.
Yeb, Thanks.

Perhaps, did you tried flush page before the writing?
I think arm64 have no d-cache alising problem but worth to try it.
Who knows :)
I thought that flush_dcache_page() is only for cases when we write
to page (store that makes pages dirty), isn't it?

	-ss
quoted hunk ↗ jump to hunk
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 46da1c4..a3a5520 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -612,6 +612,8 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, u32 index,
 	unsigned long element;
 
 	page = bvec->bv_page;
+	flush_dcache_page(page);
+
 	if (is_partial_io(bvec)) {
 		/*
 		 * This is a partial IO. We need to read the full page
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help