Thread (9 messages) 9 messages, 4 authors, 2016-12-19

Re: [PATCH] mm: simplify node/zone name printing

From: Michal Hocko <mhocko@kernel.org>
Date: 2016-12-19 08:12:14
Also in: lkml

On Mon 19-12-16 16:32:28, Sergey Senozhatsky wrote:
[...]
as far as I can tell, now for_each_populated_zone() iterations are
split by non-CONT printk() from show_zone_node(), which previously
has been   printk(KERN_CONT "%s: ", zone->name), so pr_cont(\n)
between iterations was important, but now that non-CONT printk()
should do the trick. it's _a bit_ hacky, though.
Do you consider that more hacky than the original? At least for me,
starting with KERN_CONT and relying on an explicit \n sounds more error
prone than leaving the last pr_cont without \n and relying on the
implicit flushing.
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help