On 10/23/2016 09:31 PM, Anshuman Khandual wrote:

+#ifdef CONFIG_COHERENT_DEVICE
+		/*
+		 * Isolation requiring coherent device memory node's zones
+		 * should not be part of any other node's fallback zonelist
+		 * but it's own fallback list.
+		 */
+		if (isolated_cdm_node(node) && (pgdat->node_id != node))
+			continue;
+#endif

Total nit:  Why do you need an #ifdef here when you had

+#ifdef CONFIG_COHERENT_DEVICE
+#define node_cdm(nid)          (NODE_DATA(nid)->coherent_device)
+#define set_cdm_isolation(nid) (node_cdm(nid) = 1)
+#define clr_cdm_isolation(nid) (node_cdm(nid) = 0)
+#define isolated_cdm_node(nid) (node_cdm(nid) == 1)
+#else
+#define set_cdm_isolation(nid) ()
+#define clr_cdm_isolation(nid) ()
+#define isolated_cdm_node(nid) (0)
+#endif

in your last patch?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>