On Tue, Aug 2, 2016 at 2:34 PM, Andrey Ryabinin [off-list ref] wrote:

On 08/02/2016 02:39 PM, Alexander Potapenko wrote:

quoted

quoted

+static void kasan_end_report(unsigned long *flags)
+{
+       pr_err("==================================================================\n");
+       add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE);

Don't we want to add the taint as early as possible once we've
detected the error?

What for?
It certainly shouldn't be before dump_stack(), otherwise on the first report the kernel will claimed as tainted.

Ah, got it. Fair enough.

quoted

quoted

+void kasan_report_double_free(struct kmem_cache *cache, void *object,
+                       s8 shadow)
+{
+       unsigned long flags;
+
+       kasan_start_report(&flags);
+       pr_err("BUG: Double free or corrupt pointer\n");

How about "Double free or freeing an invalid pointer\n"?
I think "corrupt pointer" doesn't exactly reflect where the bug is.

Ok

-- 
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>