Re: [PATCH 3/6] mm/kasan, slub: don't disable interrupts when object leaves quarantine
From: Alexander Potapenko <glider@google.com>
Date: 2016-08-01 14:47:24
Also in:
lkml
On Mon, Aug 1, 2016 at 4:45 PM, Andrey Ryabinin [off-list ref] wrote:
SLUB doesn't require disabled interrupts to call ___cache_free(). Signed-off-by: Andrey Ryabinin <redacted>
Acked-by: Alexander Potapenko <glider@google.com>
quoted hunk ↗ jump to hunk
--- mm/kasan/quarantine.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c index 65793f1..4852625 100644 --- a/mm/kasan/quarantine.c +++ b/mm/kasan/quarantine.c@@ -147,10 +147,14 @@ static void qlink_free(struct qlist_node *qlink, struct kmem_cache *cache) struct kasan_alloc_meta *alloc_info = get_alloc_info(cache, object); unsigned long flags; - local_irq_save(flags); + if (IS_ENABLED(CONFIG_SLAB)) + local_irq_save(flags); + alloc_info->state = KASAN_STATE_FREE; ___cache_free(cache, object, _THIS_IP_); - local_irq_restore(flags); + + if (IS_ENABLED(CONFIG_SLAB)) + local_irq_restore(flags); } static void qlist_free_all(struct qlist_head *q, struct kmem_cache *cache) --2.7.3 -- You received this message because you are subscribed to the Google Groups "kasan-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. To post to this group, send email to kasan-dev@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/1470062715-14077-3-git-send-email-aryabinin%40virtuozzo.com. For more options, visit https://groups.google.com/d/optout.
-- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>