Thread (61 messages) 61 messages, 5 authors, 2016-06-27

Re: [PATCH 16/27] mm: Move page mapped accounting to the node

From: Mel Gorman <hidden>
Date: 2016-06-23 08:35:08
Also in: lkml

On Tue, Jun 21, 2016 at 03:32:06PM -0700, Andrew Morton wrote:
On Tue, 21 Jun 2016 15:15:55 +0100 Mel Gorman [off-list ref] wrote:
quoted
Reclaim makes decisions based on the number of pages that are mapped
but it's mixing node and zone information. Account NR_FILE_MAPPED and
NR_ANON_PAGES pages on the node.
<wading through rejects>

Boy, the difference between

	__mod_zone_page_state(page_zone(page), ...

and

	__mod_node_page_state(page_pgdat(page), ...

is looking subtle.  When and why to use one versus the other.  I'm not
seeing any explanation of this in there but haven't yet looked hard.
I'm not sure I see the problem. One applies for zone stats and the other
is for node. Granted, care is needed to use the correct one or a random
stat is updated instead of the one intended.


-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help