Re: [PATCH v2 7/7] mm/page_alloc: introduce post allocation processing on page allocator

On Mon, Jun 06, 2016 at 05:21:45PM +0200, Vlastimil Babka wrote:

On 05/26/2016 04:37 AM, js1304@gmail.com wrote:

quoted

From: Joonsoo Kim <redacted>

This patch is motivated from Hugh and Vlastimil's concern [1].

There are two ways to get freepage from the allocator. One is using
normal memory allocation API and the other is __isolate_free_page() which
is internally used for compaction and pageblock isolation. Later usage is
rather tricky since it doesn't do whole post allocation processing
done by normal API.

One problematic thing I already know is that poisoned page would not be
checked if it is allocated by __isolate_free_page(). Perhaps, there would
be more.

We could add more debug logic for allocated page in the future and this
separation would cause more problem. I'd like to fix this situation
at this time. Solution is simple. This patch commonize some logic
for newly allocated page and uses it on all sites. This will solve
the problem.

[1] http://marc.info/?i=alpine.LSU.2.11.1604270029350.7066%40eggly.anvils%3E

Signed-off-by: Joonsoo Kim <redacted>

Yes that's much better. Hopefully introducing a function call into
prep_new_page() (or can compiler still inline it there?) doesn't
impact the fast paths though.

Looks like it is already inlined in my build environment but I will
add inline attribute.

Acked-by: Vlastimil Babka <redacted>

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>