Thread (27 messages) 27 messages, 6 authors, 2016-06-20

Re: [PATCH v2 1/7] mm/compaction: split freepages without holding the zone lock

From: Joonsoo Kim <hidden>
Date: 2016-06-15 02:25:29
Also in: lkml

On Tue, Jun 14, 2016 at 03:10:21PM -0400, Sasha Levin wrote:
On 06/14/2016 01:52 AM, Joonsoo Kim wrote:
quoted
On Mon, Jun 13, 2016 at 04:31:15PM -0400, Sasha Levin wrote:
quoted
quoted
On 05/25/2016 10:37 PM, js1304@gmail.com wrote:
quoted
quoted
From: Joonsoo Kim <redacted>

We don't need to split freepages with holding the zone lock. It will cause
more contention on zone lock so not desirable.

Signed-off-by: Joonsoo Kim <redacted>
Hey Joonsoo,
Hello, Sasha.
quoted
quoted
I'm seeing the following corruption/crash which seems to be related to
this patch:
Could you tell me why you think that following corruption is related
to this patch? list_del() in __isolate_free_page() is unchanged part.

Before this patch, we did it by split_free_page() ->
__isolate_free_page() -> list_del(). With this patch, we do it by
calling __isolate_free_page() directly.
I haven't bisected it, but it's the first time I see this issue and this
commit seems to have done related changes that might cause this.

I can go ahead with bisection if you don't think it's related.
Hmm... I can't find a bug in this patch for now. There are more candidates
on this area hat changed by me and it would be very helpful if you can
do bisection.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help