Re: [RFC PATCH 3/3] slub: fallback to get_numa_mem() node if we want to allocate on memoryless node
From: Christoph Lameter <hidden>
Date: 2014-02-07 17:50:02
Also in:
linuxppc-dev
From: Christoph Lameter <hidden>
Date: 2014-02-07 17:50:02
Also in:
linuxppc-dev
On Fri, 7 Feb 2014, Joonsoo Kim wrote:
quoted
This check wouild need to be something that checks for other contigencies in the page allocator as well. A simple solution would be to actually run a GFP_THIS_NODE alloc to see if you can grab a page from the proper node. If that fails then fallback. See how fallback_alloc() does it in slab.Hello, Christoph. This !node_present_pages() ensure that allocation on this node cannot succeed. So we can directly use numa_mem_id() here.
Yes of course we can use numa_mem_id(). But the check is only for not having any memory at all on a node. There are other reason for allocations to fail on a certain node. The node could have memory that cannot be reclaimed, all dirty, beyond certain thresholds, not in the current set of allowed nodes etc etc. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>