Thread (84 messages) 84 messages, 6 authors, 2013-01-08

Re: [PATCH 00/49] Automatic NUMA Balancing v10

From: Ingo Molnar <mingo@kernel.org>
Date: 2012-12-10 11:54:06
Also in: lkml
Subsystem: scheduler, the rest · Maintainers: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot, Linus Torvalds

* Ingo Molnar [off-list ref] wrote:
quoted
reasons. As it turns out, a printk() bodge showed that 
nr_cpus_allowed == 80 set in sched_init_smp() while 
num_online_cpus() == 48. This effectively disabling 
numacore. If you had responded to the bug report, this would 
likely have been found last Wednesday.
Does changing it from num_online_cpus() to num_possible_cpus() 
help? (Can send a patch if you want.)
I.e. something like the patch below.

Thanks,

	Ingo
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 503ec29..9d11a8a 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2646,7 +2646,7 @@ static bool task_numa_candidate(struct task_struct *p)
 
 	/* Don't disturb hard-bound tasks: */
 	if (sched_feat(NUMA_EXCLUDE_AFFINE)) {
-		if (p->nr_cpus_allowed != num_online_cpus())
+		if (p->nr_cpus_allowed != num_possible_cpus())
 			return false;
 	}
 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help