Re: [PATCH v7 01/16] hashtable: introduce a small and naive hashtable
From: Sasha Levin <hidden>
Date: 2012-10-29 16:07:09
Also in:
dm-devel, linux-nfs, lkml, netdev
From: Sasha Levin <hidden>
Date: 2012-10-29 16:07:09
Also in:
dm-devel, linux-nfs, lkml, netdev
On Mon, Oct 29, 2012 at 7:29 AM, Mathieu Desnoyers [off-list ref] wrote:
* Sasha Levin (levinsasha928@gmail.com) wrote:quoted
+ + for (i = 0; i < sz; i++) + INIT_HLIST_HEAD(&ht[sz]);ouch. How did this work ? Has it been tested at all ? sz -> i
Funny enough, it works perfectly. Generally as a test I boot the kernel in a VM and let it fuzz with trinity for a bit, doing that with the code above worked flawlessly. While it works, it's obviously wrong. Why does it work though? Usually there's a list op happening pretty soon after that which brings the list into proper state. I've been playing with a patch that adds a magic value into list_head if CONFIG_DEBUG_LIST is set, and checks that magic in the list debug code in lib/list_debug.c. Does it sound like something useful? If so I'll send that patch out. Thanks, Sasha -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>