On 09/27/2012 06:32 PM, Christoph Lameter wrote:

On Thu, 27 Sep 2012, Glauber Costa wrote:

quoted

On 09/27/2012 12:18 AM, Christoph Lameter wrote:

quoted

-	node = numa_mem_id();
-
 	/* 1) create the kmem_cache */
-	INIT_LIST_HEAD(&slab_caches);
-	list_add(&kmem_cache->list, &slab_caches);
-	kmem_cache->colour_off = cache_line_size();
-	kmem_cache->array[smp_processor_id()] = &initarray_cache.cache;

 	/*

Don't you have to initialize this list head somewhere ?
You are deleting this code, but not putting it back anywhere.

Thought the declaration would do the initialization in mm/slab_common.c:

enum slab_state slab_state;
LIST_HEAD(slab_caches);
DEFINE_MUTEX(slab_mutex);
struct kmem_cache *kmem_cache;

Fair enough. Because you were removing this in this patch, I was
expecting it to go somewhere in this patch as well. But we were actually
initializing this twice, in which case the current code seems fine.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>