Thread (4 messages) 4 messages, 2 authors, 2012-09-27

Re: CK1 [04/13] slab: Use the new create_boot_cache function to simplify bootstrap

From: Christoph Lameter <hidden>
Date: 2012-09-27 14:32:19

On Thu, 27 Sep 2012, Glauber Costa wrote:
On 09/27/2012 12:18 AM, Christoph Lameter wrote:
quoted
-	node = numa_mem_id();
-
 	/* 1) create the kmem_cache */
-	INIT_LIST_HEAD(&slab_caches);
-	list_add(&kmem_cache->list, &slab_caches);
-	kmem_cache->colour_off = cache_line_size();
-	kmem_cache->array[smp_processor_id()] = &initarray_cache.cache;

 	/*
Don't you have to initialize this list head somewhere ?
You are deleting this code, but not putting it back anywhere.
Thought the declaration would do the initialization in mm/slab_common.c:

enum slab_state slab_state;
LIST_HEAD(slab_caches);
DEFINE_MUTEX(slab_mutex);
struct kmem_cache *kmem_cache;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help