Re: [PATCH 4/4] mm: remove free_page_mlock
From: Johannes Weiner <hannes@cmpxchg.org>
Date: 2012-09-19 17:21:45
Also in:
lkml
From: Johannes Weiner <hannes@cmpxchg.org>
Date: 2012-09-19 17:21:45
Also in:
lkml
On Tue, Sep 18, 2012 at 08:57:27PM -0700, Hugh Dickins wrote:
We should not be seeing non-0 unevictable_pgs_mlockfreed any longer. So remove free_page_mlock() from the page freeing paths: __PG_MLOCKED is already in PAGE_FLAGS_CHECK_AT_FREE, so free_pages_check() will now be checking it, reporting "BUG: Bad page state" if it's ever found set. Comment UNEVICTABLE_MLOCKFREED and unevictable_pgs_mlockfreed always 0.
I would have just removed it because I don't see too many users relying on it being there. But I'm fine with keeping it for now.
Signed-off-by: Hugh Dickins <hughd@google.com> Cc: Mel Gorman <redacted> Cc: Rik van Riel <redacted> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Michel Lespinasse <redacted> Cc: Ying Han <redacted>
Acked-by: Johannes Weiner <hannes@cmpxchg.org> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>