Re: [PATCH 2/4] mm: remove vma arg from page_evictable
From: Johannes Weiner <hannes@cmpxchg.org>
Date: 2012-09-19 16:46:33
Also in:
lkml
From: Johannes Weiner <hannes@cmpxchg.org>
Date: 2012-09-19 16:46:33
Also in:
lkml
On Tue, Sep 18, 2012 at 08:53:45PM -0700, Hugh Dickins wrote:
page_evictable(page, vma) is an irritant: almost all its callers pass NULL for vma. Remove the vma arg and use mlocked_vma_newpage(vma, page) explicitly in the couple of places it's needed. But in those places we don't even need page_evictable() itself! They're dealing with a freshly allocated anonymous page, which has no "mapping" and cannot be mlocked yet. Signed-off-by: Hugh Dickins <hughd@google.com> Cc: Mel Gorman <redacted> Cc: Rik van Riel <redacted> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Michel Lespinasse <redacted> Cc: Ying Han <redacted>
Much better. With documentation updates and everything, thank you! Acked-by: Johannes Weiner <hannes@cmpxchg.org> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>