2012/8/25 Christoph Lameter [off-list ref]:

On Sat, 25 Aug 2012, Joonsoo Kim wrote:

quoted

index d597530..c96e0e4 100644

--- a/mm/slub.c
+++ b/mm/slub.c

@@ -1538,6 +1538,7 @@ static void *get_partial_node(struct kmem_cache *s,
 {
      struct page *page, *page2;
      void *object = NULL;
+     int cpu_slab_objects = 0, pobjects = 0;

We really need be clear here.

One counter is for the numbe of objects in the per cpu slab and the other
for the objects in tbhe per cpu partial lists.

So I think the first name is ok. Second should be similar

cpu_partial_objects?

Okay! It looks good.
But, when using "cpu_partial_objects", I have a coding style problem.

                if (kmem_cache_debug(s)
                        || cpu_slab_objects + cpu_partial_objects
                                                > s->max_cpu_object / 2)

Do you have any good idea?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>