Re: [PATCH V7 2/2] mm: memcg detect no memcgs above softlimit under zone reclaim
From: Rik van Riel <hidden>
Date: 2012-07-31 17:25:57
On 07/31/2012 11:59 AM, Michal Hocko wrote:
quoted
@@ -1899,6 +1907,11 @@ static void shrink_zone(struct zone *zone, struct scan_control *sc) } memcg = mem_cgroup_iter(root, memcg,&reclaim); } while (memcg); + + if (!over_softlimit) {Is this ever false? At least root cgroup is always above the limit. Shouldn't we rather compare reclaimed pages?
Uh oh. That could also result in us always reclaiming from the root cgroup first... Is that really what we want? Having said that, in April I discussed an algorithm of LRU list weighting with Ying and others that should work. Ying's patches look like a good basis to implement that on top of... -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>