Re: [RFC][PATCH 02/26] mm, mpol: Remove NUMA_INTERLEAVE_HIT
From: Peter Zijlstra <hidden>
Date: 2012-07-06 15:01:42
Also in:
lkml
From: Peter Zijlstra <hidden>
Date: 2012-07-06 15:01:42
Also in:
lkml
On Fri, 2012-07-06 at 23:54 +0900, Kyungmin Park wrote:
quoted
static struct zonelist *policy_zonelist(gfp_t gfp, struct mempolicy *policy, int nd) { switch (policy->mode) { + case MPOL_INTERLEAVE: + nd = interleave_nodes(policy);Jut nitpick, Original code also uses the 'unsigned nid' but now it assigned 'unsigned nid' to 'int nd' at here. does it right?
node id is generally signed, we use -1 as a special value indicating no node preference in a number of places. Not sure why it was unsigned here. Also I think even SGI isn't anywhere near 2^31 nodes. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>