Re: [PATCH] slub: change cmpxchg_double_slab in get_freelist() to __cmpxchg_double_slab
From: JoonSoo Kim <hidden>
Date: 2012-06-01 12:18:25
Also in:
lkml
From: JoonSoo Kim <hidden>
Date: 2012-06-01 12:18:25
Also in:
lkml
We now made get_freelist() *require* interrupts to be disabled which deserves a comment, no?
I resend patch(18 May) related to this comment. See below link. http://thread.gmane.org/gmane.linux.kernel.mm/78630/focus=78701
Also, what do we gain from patches like this? It's somewhat counterintuitive that we have a function with "cmpxchg" in it which is not always atomic (i.e. you need to have interrupts disabled).
Hmm... This patch have a minor impact which saves a few instructions. But we already have a "__cmpxchg" version which works in irq disabled, so there is no reason for not applying it. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>