On Mon, 14 May 2012, David Rientjes wrote:

quoted

On Fri, 11 May 2012, Joonsoo Kim wrote:

quoted

get_freelist() is only called by __slab_alloc with interrupt disabled,
so __cmpxchg_double_slab is suitable.

Signed-off-by: Joonsoo Kim <redacted>

Acked-by: David Rientjes <rientjes@google.com>

On Thu, 31 May 2012, David Rientjes wrote:

Pekka, did you want to pick this up so it can get into linux-next?

We now made get_freelist() *require* interrupts to be disabled which 
deserves a comment, no?

Also, what do we gain from patches like this? It's somewhat 
counterintuitive that we have a function with "cmpxchg" in it which is not 
always atomic (i.e. you need to have interrupts disabled).

IIRC, there was even a long rant about this by Linus but I'm unable to 
find it in my email archives.

			Pekka

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>