[PATCH 7/9] mm: pass __GFP_WRITE to memcg charge and reclaim routines
From: Fengguang Wu <hidden>
Date: 2012-02-28 14:57:07
Also in:
lkml
__GFP_WRITE will be tested in vmscan to find out the write tasks. For good interactive performance, we try to focus dirty reclaim waits on them and avoid blocking unrelated tasks. Signed-off-by: Fengguang Wu <redacted> --- include/linux/gfp.h | 2 +- mm/filemap.c | 13 +++++++------ 2 files changed, 8 insertions(+), 7 deletions(-)
--- linux.orig/include/linux/gfp.h 2012-02-28 10:22:24.000000000 +0800
+++ linux/include/linux/gfp.h 2012-02-28 10:22:42.936316697 +0800@@ -129,7 +129,7 @@ struct vm_area_struct; /* Control page allocator reclaim behavior */ #define GFP_RECLAIM_MASK (__GFP_WAIT|__GFP_HIGH|__GFP_IO|__GFP_FS|\ __GFP_NOWARN|__GFP_REPEAT|__GFP_NOFAIL|\ - __GFP_NORETRY|__GFP_NOMEMALLOC) + __GFP_NORETRY|__GFP_NOMEMALLOC|__GFP_WRITE) /* Control slab gfp mask during early boot */ #define GFP_BOOT_MASK (__GFP_BITS_MASK & ~(__GFP_WAIT|__GFP_IO|__GFP_FS)) --- linux.orig/mm/filemap.c 2012-02-28 10:22:25.000000000 +0800 +++ linux/mm/filemap.c 2012-02-28 10:24:12.320318821 +0800
@@ -2340,21 +2340,22 @@ struct page *grab_cache_page_write_begin int status; gfp_t gfp_mask; struct page *page; - gfp_t gfp_notmask = 0; + gfp_t lru_gfp_mask = GFP_KERNEL | __GFP_WRITE; gfp_mask = mapping_gfp_mask(mapping) | __GFP_WRITE; - if (flags & AOP_FLAG_NOFS) - gfp_notmask = __GFP_FS; + if (flags & AOP_FLAG_NOFS) { + gfp_mask &= ~__GFP_FS; + lru_gfp_mask &= ~__GFP_FS; + } repeat: page = find_lock_page(mapping, index); if (page) goto found; - page = __page_cache_alloc(gfp_mask & ~gfp_notmask); + page = __page_cache_alloc(gfp_mask); if (!page) return NULL; - status = add_to_page_cache_lru(page, mapping, index, - GFP_KERNEL & ~gfp_notmask); + status = add_to_page_cache_lru(page, mapping, index, lru_gfp_mask); if (unlikely(status)) { page_cache_release(page); if (status == -EEXIST) --
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>