Thread (19 messages) 19 messages, 5 authors, 2012-02-20

Re: [PATCH 2/6] thp: optimize away unnecessary page table locking

From: KAMEZAWA Hiroyuki <hidden>
Date: 2012-02-09 02:21:12
Also in: lkml

On Wed,  8 Feb 2012 10:51:38 -0500
Naoya Horiguchi [off-list ref] wrote:
Currently when we check if we can handle thp as it is or we need to
split it into regular sized pages, we hold page table lock prior to
check whether a given pmd is mapping thp or not. Because of this,
when it's not "huge pmd" we suffer from unnecessary lock/unlock overhead.
To remove it, this patch introduces a optimized check function and
replace several similar logics with it.

Signed-off-by: Naoya Horiguchi <redacted>
Cc: David Rientjes <rientjes@google.com>
I prefer 'bool' for return type..but seems much better.

Thank you. I think this clean up is very good.

Reviewed-by: KAMEZAWA Hiroyuki <redacted>


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help