Re: [PATCH v9 3.2 2/9] uprobes: handle breakpoint and signal step exception.
From: Srikar Dronamraju <hidden>
Date: 2012-01-25 08:22:28
Also in:
lkml
From: Srikar Dronamraju <hidden>
Date: 2012-01-25 08:22:28
Also in:
lkml
quoted
quoted
One question that could be asked is why arent we using instruction_pointer instead of GET_IP since instruction_pointer is being defined in 25 places and with references in 120 places.i think you misunderstand the point. {G,S}ET_IP() is the glue between the arch's pt_regs struct and the public facing API. the only people who should be touching those macros are the ptrace core. instruction_pointer() and instruction_pointer_set() are the API that asm/ptrace.h exports to the rest of the tree.Srikar: does that make sense ? i'm happy to help with improving asm-generic/ptrace.h. -mike
Yes, I think it makes sense. I have modified the code to use instruction_pointer_set instead of set_instruction_pointer. -- Thanks and Regards Srikar -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>