Re: [PATCH 7/9] readahead: add vfs/readahead tracing event
From: Christoph Hellwig <hch@infradead.org>
Date: 2011-12-06 15:30:25
Also in:
linux-fsdevel, lkml
+ TP_printk("readahead-%s(dev=%d:%d, ino=%lu, "please don't duplicate the tracepoint name in the output string. Also don't use braces, as it jsut complicates parsing.
+ "req=%lu+%lu, ra=%lu+%d-%d, async=%d) = %d", + ra_pattern_names[__entry->pattern],
Instead of doing a manual array lookup please use __print_symbolic so that users of the binary interface (like trace-cmd) also get the right output.
quoted hunk ↗ jump to hunk
--- linux-next.orig/mm/readahead.c 2011-11-29 20:58:53.000000000 +0800 +++ linux-next/mm/readahead.c 2011-11-29 20:59:20.000000000 +0800@@ -29,6 +29,9 @@ static const char * const ra_pattern_nam [RA_PATTERN_ALL] = "all", }; +#define CREATE_TRACE_POINTS +#include <trace/events/vfs.h>
Maybe we should create a new fs/trace.c just for this instead of stickin it into the first file that created a tracepoint in the "vfs" namespace. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>