Thread (45 messages) 45 messages, 9 authors, 2011-11-30

Re: [PATCH 5/8] readahead: add /debug/readahead/stats

From: Wu Fengguang <hidden>
Date: 2011-11-22 14:14:20
Also in: linux-fsdevel, lkml

Andi,

On Mon, Nov 21, 2011 at 10:17:59PM +0800, Andi Kleen wrote:
quoted
+static unsigned long ra_stats[RA_PATTERN_MAX][RA_ACCOUNT_MAX];
Why not make it per cpu?  That should get the overhead down, probably
even enough that it can be enabled by default.

BTW I have an older framework to make it really easy to add per
cpu stats counters to debugfs. Will repost, that would simplify
it even more.
That's definitely a good facility to have. I would be happy to become
its first user :)

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help