Thread (45 messages) 45 messages, 6 authors, 2011-11-28

Re: [patch 4/8] mm: memcg: lookup_page_cgroup (almost) never returns NULL

From: Johannes Weiner <hannes@cmpxchg.org>
Date: 2011-11-28 09:17:15
Also in: cgroups, lkml

On Mon, Nov 28, 2011 at 12:33:31PM +0530, Balbir Singh wrote:
On Wed, Nov 23, 2011 at 9:12 PM, Johannes Weiner [off-list ref] wrote:
quoted
From: Johannes Weiner <redacted>

Pages have their corresponding page_cgroup descriptors set up before
they are used in userspace, and thus managed by a memory cgroup.

The only time where lookup_page_cgroup() can return NULL is in the
page sanity checking code that executes while feeding pages into the
page allocator for the first time.
This is a legacy check from the days when we allocated PC during fault
time on demand. It might make sense to assert on !pc in DEBUG_VM mode
at some point in the future
I don't think a BUG_ON bears more information than a null-pointer
dereference.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help