Re: [patch 4/8] mm: memcg: lookup_page_cgroup (almost) never returns NULL
From: Johannes Weiner <hidden>
Date: 2011-11-28 09:17:15
Also in:
linux-mm, lkml
From: Johannes Weiner <hidden>
Date: 2011-11-28 09:17:15
Also in:
linux-mm, lkml
On Mon, Nov 28, 2011 at 12:33:31PM +0530, Balbir Singh wrote:
On Wed, Nov 23, 2011 at 9:12 PM, Johannes Weiner [off-list ref] wrote:quoted
From: Johannes Weiner <redacted> Pages have their corresponding page_cgroup descriptors set up before they are used in userspace, and thus managed by a memory cgroup. The only time where lookup_page_cgroup() can return NULL is in the page sanity checking code that executes while feeding pages into the page allocator for the first time.This is a legacy check from the days when we allocated PC during fault time on demand. It might make sense to assert on !pc in DEBUG_VM mode at some point in the future
I don't think a BUG_ON bears more information than a null-pointer dereference. -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html