Michal Hocko wrote:

On Fri 26-08-11 14:03:17, Konstantin Khlebnikov wrote:

quoted

Michal Hocko wrote:

quoted

@@ -450,6 +459,10 @@ static int oom_kill_task(struct task_struct *p, struct mem_cgroup *mem)
  			pr_err("Kill process %d (%s) sharing same memory\n",
  				task_pid_nr(q), q->comm);
  			task_unlock(q);
+
+			if (frozen(q))
+				thaw_process(q);
+

We must thaw task strictly after sending SIGKILL.

Sounds reasonable.

quoted

But anyway I think this is a bad idea.

Why?

Refrigerator may be used for digging in task's internal structures,
so such digger may be very surprised if somebody suddenly thaws this task.

quoted

quoted

  			force_sig(SIGKILL, q);
  		}

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>