Thread (44 messages) 44 messages, 7 authors, 2011-09-27

Re: [PATCH] oom: skip frozen tasks

From: Michal Hocko <hidden>
Date: 2011-08-26 10:48:31
Also in: lkml

On Fri 26-08-11 14:03:17, Konstantin Khlebnikov wrote:
Michal Hocko wrote:
quoted
@@ -450,6 +459,10 @@ static int oom_kill_task(struct task_struct *p, struct mem_cgroup *mem)
 			pr_err("Kill process %d (%s) sharing same memory\n",
 				task_pid_nr(q), q->comm);
 			task_unlock(q);
+
+			if (frozen(q))
+				thaw_process(q);
+
We must thaw task strictly after sending SIGKILL.
Sounds reasonable.
But anyway I think this is a bad idea.
Why?
quoted
 			force_sig(SIGKILL, q);
 		}
-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help