[PATCH 4/9] mm: use get_page in deactivate_page()
From: Michel Lespinasse <hidden>
Date: 2011-08-19 07:49:23
Also in:
lkml
Subsystem:
memory management, memory management - mglru (multi-gen lru), memory management - swap, the rest · Maintainers:
Andrew Morton, Chris Li, Kairui Song, Linus Torvalds
deactivate_page() already holds a reference to the page, so it can use get_page() instead of get_page_unless_zero(). Signed-off-by: Michel Lespinasse <redacted> --- mm/swap.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/mm/swap.c b/mm/swap.c
index ac617dc..11574b1 100644
--- a/mm/swap.c
+++ b/mm/swap.c@@ -517,6 +517,8 @@ static void drain_cpu_pagevecs(int cpu) */ void deactivate_page(struct page *page) { + struct pagevec *pvec; + /* * In a workload with many unevictable page such as mprotect, unevictable * page deactivation for accelerating reclaim is pointless.
@@ -524,13 +526,11 @@ void deactivate_page(struct page *page) if (PageUnevictable(page)) return; - if (likely(get_page_unless_zero(page))) { - struct pagevec *pvec = &get_cpu_var(lru_deactivate_pvecs); - - if (!pagevec_add(pvec, page)) - pagevec_lru_move_fn(pvec, lru_deactivate_fn, NULL); - put_cpu_var(lru_deactivate_pvecs); - } + get_page(page); + pvec = &get_cpu_var(lru_deactivate_pvecs); + if (!pagevec_add(pvec, page)) + pagevec_lru_move_fn(pvec, lru_deactivate_fn, NULL); + put_cpu_var(lru_deactivate_pvecs); } void lru_add_drain(void)
--
1.7.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>