Thread (35 messages) 35 messages, 3 authors, 2011-08-19
STALE5426d

[PATCH] memcg: fix comment on update nodemask

From: KAMEZAWA Hiroyuki <hidden>
Date: 2011-08-10 23:52:19
Also in: lkml

quoted
quoted
 /*
  * Always updating the nodemask is not very good - even if we have an empty
  * list or the wrong list here, we can start from some node and traverse all
@@ -1575,7 +1593,6 @@ static bool test_mem_cgroup_node_reclaim
  */
Would be good to update the function comment as well (we still have 10s
period there).
how about this ?
==

Update function's comment. The behavior is changed by commit 453a9bf3

Signed-off-by: KAMEZAWA Hiroyuki <redacted>

---
 mm/memcontrol.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Index: mmotm-Aug3/mm/memcontrol.c
===================================================================
--- mmotm-Aug3.orig/mm/memcontrol.c
+++ mmotm-Aug3/mm/memcontrol.c
@@ -1568,10 +1568,7 @@ static bool test_mem_cgroup_node_reclaim
 #if MAX_NUMNODES > 1
 
 /*
- * Always updating the nodemask is not very good - even if we have an empty
- * list or the wrong list here, we can start from some node and traverse all
- * nodes based on the zonelist. So update the list loosely once per 10 secs.
- *
+ * Update scan nodemask with memcg's event_counter(NUMAINFO_EVENTS_TARGET)
  */
 static void mem_cgroup_may_update_nodemask(struct mem_cgroup *mem)
 {

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help