Re: [patch 3/3]vmscan: cleanup kswapd_try_to_sleep
From: Mel Gorman <mgorman@suse.de>
Date: 2011-07-28 11:03:10
From: Mel Gorman <mgorman@suse.de>
Date: 2011-07-28 11:03:10
On Thu, Jul 28, 2011 at 04:13:09PM +0800, Shaohua Li wrote:
cleanup kswapd_try_to_sleep() a little bit. Sometimes kswapd doesn't really sleep. In such case, don't call prepare_to_wait/finish_wait. It just wastes CPU. Signed-off-by: Shaohua Li <redacted>
Out of curiousity, under what circumstances is the CPU usage noticeable? The patch itself seems fine so; Acked-by: Mel Gorman <mgorman@suse.de> -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>