Thread (15 messages) 15 messages, 6 authors, 2011-06-20

[BUGFIX][PATCH][-rc3] Define a consolidated definition of node_start/end_pfn for build error in page_cgroup.c (Was Re: mmotm 2011-06-15-16-56 uploaded (mm/page_cgroup.c)

From: KAMEZAWA Hiroyuki <hidden>
Date: 2011-06-17 00:46:28
Also in: linux-fsdevel, lkml
Subsystem: alpha port, linux for powerpc (32-bit and 64-bit), memory management - core, memory management - mglru (multi-gen lru), parisc architecture, sparc + ultrasparc (sparc/sparc64), superh, the rest, x86 architecture (32-bit and 64-bit) · Maintainers: Richard Henderson, Matt Turner, Magnus Lindholm, Madhavan Srinivasan, Michael Ellerman, Andrew Morton, David Hildenbrand, "James E.J. Bottomley", Helge Deller, "David S. Miller", Andreas Larsson, Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz, Linus Torvalds, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen

On Thu, 16 Jun 2011 11:35:59 +0100
Mel Gorman [off-list ref] wrote:
A caller that does node_end_pfn(nid++) will get a nasty surprise
due to side-effects. I know architectures currently get this wrong
including x86_64 but we might as well fix it up now. The definition
in arch/x86/include/asm/mmzone_32.h is immune to side-effects and
might be a better choice despite the use of a temporary variable.
Ok, here is a fixed one. Thank you for comments/review.
==
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help