On Wed, Mar 23, 2011 at 1:09 AM, KOSAKI Motohiro
[off-list ref] wrote:

When __lock_page_or_retry() return 0, It call up_read(mmap_sem) in this
function.

Indeed.

I agree this is strange (or ugly). but I don't want change this spec in
this time.

I agree that it is strange, and I don't like functions that touch
locks that they didn't take themselves, but since the original point
of the whole thing was to wait for the page without holding the
mmap_sem lock, that function has to do the up_read() early.

                   Linus

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>