Re: [PATCH] mm: fix dubious code in __count_immobile_pages()
From: KAMEZAWA Hiroyuki <hidden>
Date: 2011-02-21 10:04:16
Also in:
lkml
On Fri, 18 Feb 2011 10:46:26 +0900 Namhyung Kim [off-list ref] wrote:
When pfn_valid_within() failed 'iter' was incremented twice. Signed-off-by: Namhyung Kim <redacted> Cc: KAMEZAWA Hiroyuki <redacted>
Thank you. Reviewed-by: KAMEZAWA Hiroyuki <redacted>
quoted hunk ↗ jump to hunk
--- mm/page_alloc.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e8b02771ccea..bf83d1c1d648 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c@@ -5380,10 +5380,9 @@ __count_immobile_pages(struct zone *zone, struct page *page, int count) for (found = 0, iter = 0; iter < pageblock_nr_pages; iter++) { unsigned long check = pfn + iter; - if (!pfn_valid_within(check)) { - iter++; + if (!pfn_valid_within(check)) continue; - } + page = pfn_to_page(check); if (!page_count(page)) { if (PageBuddy(page))-- 1.7.4
-- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>