Thread (4 messages) 4 messages, 3 authors, 2011-02-21

Re: [PATCH] mm: fix dubious code in __count_immobile_pages()

From: Minchan Kim <hidden>
Date: 2011-02-18 02:26:28
Also in: lkml

On Fri, Feb 18, 2011 at 10:46 AM, Namhyung Kim [off-list ref] wrote:
When pfn_valid_within() failed 'iter' was incremented twice.

Signed-off-by: Namhyung Kim <redacted>
Cc: KAMEZAWA Hiroyuki <redacted>
Reviewed-by: Minchan Kim <redacted>

Nitpick.

I am not sure it's best. I don't like below trick.
iter += (1 << page_order(page)) - 1;

So we can change for loop with while as removing -1 trick of PageBuddy.
But if you don't like it, I don't mind it. :)

Thanks!

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help