Thread (17 messages) 17 messages, 3 authors, 2004-08-06

Re: [PATCH] 1/4: rework alloc_pages

From: Nick Piggin <hidden>
Date: 2004-08-06 05:29:22

Andrew Morton wrote:
Nick Piggin [off-list ref] wrote:
quoted
Previously the ->protection[] logic was broken. It was difficult to follow
and basically didn't use the asynch reclaim watermarks properly.

eh?

Broken how?
min = (1<<order) + z->protection[alloc_type];

This value is used both as the condition for waking kswapd, and
whether or not to enter synch reclaim.

What should happen is kswapd gets woken at pages_low, and synch
reclaim is started at pages_min.
What is an "asynch reclaim watermark"?
pages_low and pages_high.
quoted
This one uses ->protection only for lower-zone protection, and gives the
allocator flexibility to add the watermarks as desired.

eh?
pages_low + protection and pages_min + protection, etc.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help