On Thu, 2002-07-25 at 14:40, Andrew Morton wrote:

Rik van Riel wrote:

quoted

On Thu, 25 Jul 2002, Christoph Hellwig wrote:

quoted

This function (start_aggressive_readahead()) checks whether all zones
of the given gfp mask have lots of free pages.

Seems a bit silly since ideally we wouldn't reclaim cache memory
until we're low on physical memory.

Yes, I would question its worth also.


What it boils down to is:  which pages are we, in the immediate future,
more likely to use?  Pages which are at the tail of the inactive list,
or pages which are in the file's readahead window?

I'd say the latter, so readahead should just go and do reclaim.

The interesting thing is that tuning metadata readahead using
this function does indeed improve performance under heavy memory
load. It seems we end up pushing more useful things out of
memory than the metadata we read in. Andrew, you talked about
a GFP flag which would mean only return memory if there was
some available which was already free and clean. The best
approach might be to use that flag in this scenario and skip
the readahead if no memory is returned.

For the record, this is not just used for directory readahead,
but for any btree structured metadata in xfs.

Steve


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/