Thread (6 messages) 6 messages, 3 authors, 2002-07-19

Re: [patch] Useless locking in mm/numa.c

From: Kanoj Sarcar <hidden>
Date: 2002-07-19 18:40:58

--- William Lee Irwin III <wli@holomorphy.com> wrote:
On Fri, Jul 19, 2002 at 11:36:46AM -0700, Kanoj
Sarcar wrote:
quoted
I think I put in the locks in the initial version
of
quoted
the file becase the idea was that 
show_free_areas_node() could be invoked from any
cpu
quoted
in a multinode system (via the sysrq keys or other
intr sources), and the spin lock would provide 
sanity in the print out. 
For nonnuma discontig machines, isn't the spin
lock
quoted
providing protection in the pgdat list chain
walking
quoted
in _alloc_pages()?
Kanoj
Since I just posted a patch removing the entire
function, exactly
where is this called from? A grep of current 2.5
shows that it's
never called from anywhere.


Cheers,
Bill
Ok. I was just pointing out why the lock was added
initially. The reasons might not make sense anymore.

Kanoj


__________________________________________________
Do You Yahoo!?
Yahoo! Autos - Get free new car price quotes
http://autos.yahoo.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help