Re: [patch] Useless locking in mm/numa.c
From: William Lee Irwin III <hidden>
Date: 2002-07-19 18:38:44
From: William Lee Irwin III <hidden>
Date: 2002-07-19 18:38:44
On Fri, Jul 19, 2002 at 11:36:46AM -0700, Kanoj Sarcar wrote:
I think I put in the locks in the initial version of the file becase the idea was that show_free_areas_node() could be invoked from any cpu in a multinode system (via the sysrq keys or other intr sources), and the spin lock would provide sanity in the print out. For nonnuma discontig machines, isn't the spin lock providing protection in the pgdat list chain walking in _alloc_pages()? Kanoj
Since I just posted a patch removing the entire function, exactly where is this called from? A grep of current 2.5 shows that it's never called from anywhere. Cheers, Bill -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/