[PATCH v2 03/24] arm/cpu: Make sure arch_cpu_idle_dead() doesn't return
From: Josh Poimboeuf <jpoimboe@kernel.org>
Date: 2023-02-14 07:07:47
Also in:
linux-alpha, linux-arm-kernel, linux-sh, linuxppc-dev, lkml, loongarch, sparclinux
Subsystem:
arm port, the rest · Maintainers:
Russell King, Linus Torvalds
arch_cpu_idle_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org> --- arch/arm/kernel/smp.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
index 0b8c25763adc..adcd417c526b 100644
--- a/arch/arm/kernel/smp.c
+++ b/arch/arm/kernel/smp.c@@ -382,6 +382,8 @@ void arch_cpu_idle_dead(void) : "r" (task_stack_page(current) + THREAD_SIZE - 8), "r" (current) : "r0"); + + BUG(); } #endif /* CONFIG_HOTPLUG_CPU */
--
2.39.1