Re: [PATCH] MIPS: Do not define pci_remap_iospace() under MACH_LOONGSON64
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: 2021-12-09 09:26:10
Also in:
lkml
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: 2021-12-09 09:26:10
Also in:
lkml
On Wed, Dec 08, 2021 at 02:47:56PM +0100, Sergio Paracuellos wrote:
quoted
-#endif - #ifdef CONFIG_PCI_DRIVERS_LEGACY /*diff --git a/arch/mips/pci/pci-generic.c b/arch/mips/pci/pci-generic.c index 18eb8a453a86..d2d68bac3d25 100644 --- a/arch/mips/pci/pci-generic.c +++ b/arch/mips/pci/pci-generic.c@@ -47,6 +47,7 @@ void pcibios_fixup_bus(struct pci_bus *bus) pci_read_bridge_bases(bus); } +#ifdef pci_remap_iospace int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr) { unsigned long vaddr;@@ -60,3 +61,4 @@ int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr) set_io_port_base(vaddr); return 0; } +#endifI agree this is cleaner than the CONFIG_MACH_LOONGSON64 ifdef stuff. I have tested this changes in mt7621 ralink platform and all seem to work, so in case you want to include this, feel free to add my:
thank you for testing.
Tested-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Thomas, if you prefer me to send this as a more formal PATCH, please let me know.
Thiezhu already did, I'll add your tags the new patch. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]