Re: [patch V2 08/23] PCI/sysfs: Use pci_irq_vector()
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2021-12-07 20:56:29
Also in:
ath11k, linux-hyperv, linux-pci, linuxppc-dev, lkml, sparclinux, xen-devel
On Mon, Dec 06, 2021 at 11:27:36PM +0100, Thomas Gleixner wrote:
instead of fiddling with msi descriptors. Signed-off-by: Thomas Gleixner <redacted> Tested-by: Juergen Gross <jgross@suse.com> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com> s/msi/MSI/ above if you have a chance. Nice cleanup, thanks!
quoted hunk ↗ jump to hunk
--- drivers/pci/pci-sysfs.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)--- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c@@ -62,11 +62,8 @@ static ssize_t irq_show(struct device *d * For MSI, show the first MSI IRQ; for all other cases including * MSI-X, show the legacy INTx IRQ. */ - if (pdev->msi_enabled) { - struct msi_desc *desc = first_pci_msi_entry(pdev); - - return sysfs_emit(buf, "%u\n", desc->irq); - } + if (pdev->msi_enabled) + return sysfs_emit(buf, "%u\n", pci_irq_vector(pdev, 0)); #endif return sysfs_emit(buf, "%u\n", pdev->irq);