Hi Paul,

Am 01.12.2021 um 14:02 schrieb Paul Cercueil [off-list ref]:

Hi Nikolaus,

Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller [off-list ref] a écrit :

quoted

From: Paul Boddie <redacted>
A specialisation of the generic Synopsys HDMI driver is employed for
JZ4780 HDMI support. This requires a new driver, plus device tree and
configuration modifications.
Here we add Kconfig DRM_INGENIC_DW_HDMI, Makefile and driver code.
Signed-off-by: Paul Boddie <redacted>
Signed-off-by: Ezequiel Garcia <redacted>
Signed-off-by: H. Nikolaus Schaller <redacted>
---
drivers/gpu/drm/ingenic/Kconfig           |   9 ++
drivers/gpu/drm/ingenic/Makefile          |   1 +
drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c | 138 ++++++++++++++++++++++
3 files changed, 148 insertions(+)
create mode 100644 drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c

diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig
index 3b57f8be007c4..4efc709d77b0a 100644
--- a/drivers/gpu/drm/ingenic/Kconfig
+++ b/drivers/gpu/drm/ingenic/Kconfig

quoted

+	}
+
+	if (!regulator)
+		return 0;

Blank line here.

It is one of these cases where checkpatch doesn't complain although it should be improved...

But I can add it myself when applying.

Yes, please. So that we are not wasting mailing list bandwidth...

I'll just wait for Rob's ack first.

Indeed. Fortunately he had the right hint how to fix 3/8 quickly.

BR and thanks,
NIkolaus