Thread (26 messages) 26 messages, 3 authors, 2021-10-15

Re: [PATCH v7 18/21] auxdisplay: ht16k33: Add support for segment displays

From: Dan Carpenter <hidden>
Date: 2021-10-15 08:48:24
Also in: linux-devicetree, linux-leds, oe-kbuild, oe-kbuild-all

Hi Geert,

url:    https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/auxdisplay-ht16k33-Add-character-display-support/20211013-025705
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: i386-randconfig-m031-20211012 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>
Reported-by: Dan Carpenter <redacted>

smatch warnings:
include/uapi/linux/map_to_14segment.h:87 map_to_seg14() error: buffer overflow 'map->table' 128 <= 255
include/uapi/linux/map_to_14segment.h:87 map_to_seg14() error: buffer overflow 'map->table' 128 <= 255
include/uapi/linux/map_to_14segment.h:87 map_to_seg14() error: buffer overflow 'map->table' 128 <= 255

vim +87 include/uapi/linux/map_to_14segment.h

d26423994040a7 Geert Uytterhoeven 2021-10-12  85  static __inline__ int map_to_seg14(struct seg14_conversion_map *map, int c)
d26423994040a7 Geert Uytterhoeven 2021-10-12  86  {
d26423994040a7 Geert Uytterhoeven 2021-10-12 @87  	return c >= 0 && c < sizeof(map->table) ? __be16_to_cpu(map->table[c])
                                                                         ^^^^^^^^^^^^^^^^^^^^^^
This needs to be c < ARRAY_SIZE(map->table) instead of sizeof().

d26423994040a7 Geert Uytterhoeven 2021-10-12  88  						: -EINVAL;
d26423994040a7 Geert Uytterhoeven 2021-10-12  89  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help