Re: [PATCH] mips: mm: correct build errors for debug code in tlb-r3k
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: 2021-08-14 12:58:41
Also in:
lkml
On Fri, Aug 13, 2021 at 03:54:33PM +0200, Marcin Chojnacki wrote:
quoted hunk ↗ jump to hunk
tlb-r3k has debug code hidden under DEBUG_TLB define. This flag is undefined by default which results in the code not being compiled. If one would enable the flag, the file would not build because of the code being not up to date with the rest of this file. This commit fixes the normally hidden debug code to bring it in line with the rest of the file and make it build with the debug flag enabled. Signed-off-by: Marcin Chojnacki <redacted> --- arch/mips/mm/tlb-r3k.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)diff --git a/arch/mips/mm/tlb-r3k.c b/arch/mips/mm/tlb-r3k.c index a36622ebe..ca53f3366 100644 --- a/arch/mips/mm/tlb-r3k.c +++ b/arch/mips/mm/tlb-r3k.c@@ -77,7 +77,7 @@ void local_flush_tlb_range(struct vm_area_struct *vma, unsigned long start, unsigned long size, flags; #ifdef DEBUG_TLB - printk("[tlbrange<%lu,0x%08lx,0x%08lx>]", + printk("[tlbrange<%llu,0x%08lx,0x%08lx>]", cpu_context(cpu, mm) & asid_mask, start, end); #endif
running checkpatch over your patch gives me
WARNING: printk() should include KERN_<LEVEL> facility level
#29: FILE: arch/mips/mm/tlb-r3k.c:80:
+ printk("[tlbrange<%llu,0x%08lx,0x%08lx>]",
can you fix that as well ? Maybe be even replacing printk with
pr_debug
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]