Re: [PATCH v5 1/9] MIPS: Avoid future duplicate elf core header reservation
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-08-11 15:35:41
Also in:
kexec, linux-arm-kernel, linux-devicetree, linux-renesas-soc, linux-riscv, lkml
On Wed, Aug 11, 2021 at 10:51 AM Geert Uytterhoeven [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Prepare for early_init_fdt_scan_reserved_mem() reserving the memory occupied by an elf core header described in the device tree. As arch_mem_init() calls early_init_fdt_scan_reserved_mem() before mips_reserve_vmcore(), the latter needs to check if the memory has already been reserved before. Note that mips_reserve_vmcore() cannot just be removed, as not all MIPS systems use DT. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v5: - New. --- arch/mips/kernel/setup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c index 23a140327a0bac1b..4693add05743d78b 100644 --- a/arch/mips/kernel/setup.c +++ b/arch/mips/kernel/setup.c@@ -429,7 +429,8 @@ static void __init mips_reserve_vmcore(void) pr_info("Reserving %ldKB of memory at %ldKB for kdump\n", (unsigned long)elfcorehdr_size >> 10, (unsigned long)elfcorehdr_addr >> 10); - memblock_reserve(elfcorehdr_addr, elfcorehdr_size); + if (!memblock_is_region_reserved(elfcorehdr_addr, elfcorehdr_size)
As pointed out by lkp, there's a closing parenthesis missing. /me hides back under his rock.
+ memblock_reserve(elfcorehdr_addr, elfcorehdr_size); #endif
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds