Hi Robert,

Am 05.08.2021 um 16:32 schrieb Robert Foss [off-list ref]:

Hey Nikolaus,

Thanks for submitting this series.

On Thu, 5 Aug 2021 at 16:08, H. Nikolaus Schaller [off-list ref] wrote:

quoted

From: Paul Boddie <redacted>

static void dw_hdmi_bridge_mode_set(struct drm_bridge *bridge,
                                   const struct drm_display_mode *orig_mode,
                                   const struct drm_display_mode *mode)

@@ -2883,6 +2896,7 @@ static const struct drm_bridge_funcs dw_hdmi_bridge_funcs = {
       .atomic_disable = dw_hdmi_bridge_atomic_disable,
       .mode_set = dw_hdmi_bridge_mode_set,
       .mode_valid = dw_hdmi_bridge_mode_valid,
+       .mode_fixup = dw_hdmi_bridge_mode_fixup,

mode_fixup() has been deprecated[1] in favor of atomic_check(), care
has to be taken when switching to atomic_check() as it has access to
the full atomic commit.

Looking at this driver, it's using mode_set as well, which should be fixed.

[1] https://lore.kernel.org/dri-devel/20210722062246.2512666-8-sam@ravnborg.org/ (local)

We have moved code from mode_fixup() to atomic_check().
Was not difficult.

v3 will come soon.

BR and thanks,
Nikolaus Schaller