On 7/5/21 9:21 AM, Krzysztof Kozlowski wrote:

On Mon, 5 Jul 2021 at 18:08, Guenter Roeck [off-list ref] wrote:

quoted

On 7/5/21 8:15 AM, Krzysztof Kozlowski wrote:

quoted

On 14/05/2021 16:04, Krzysztof Kozlowski wrote:

quoted

On 14/05/2021 09:48, Guenter Roeck wrote:

quoted

On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:

quoted

When rt2880_wdt watchdog driver is built as a module, the
rt_sysc_membase needs to be exported (it is being used via inlined
rt_sysc_r32):

     ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!

Reported-by: kernel test robot <redacted>
Signed-off-by: Krzysztof Kozlowski <redacted>

Acked-by: Guenter Roeck <linux@roeck-us.net>

I don't see a recent change in the code. Has that problem been there
all along ?

I think the problem was there always but 0-day builder did not hit it
until recently:
https://lore.kernel.org/lkml/202105082122.yrF7ploN-lkp@intel.com/ (local)

Hi Guenter,

It seems that patch was not applied. Anything to fix here?

I see commit fef532ea0cd8 ("MIPS: ralink: export rt_sysc_membase for
rt2880_wdt.c"). Does that not solve the problem ?

Yes, that fixes it. It was sent later, though. :(

Happens to me all the time. What is important is that things are getting
fixed. Personally I don't care that much for the credit.

Note though that your patch subject was a bit misleading, and it may well
be possible that the mips maintainers didn't realize that the fix needed
to be applied to the mips tree. The subject line in the applied patch
describes the change much better as it focuses on the change (what is done),
while the subject line in your patch focuses on the impact (what it fixes).

Guenter