On (21/06/04 09:24), Paolo Bonzini wrote:

On 04/06/21 09:21, Vitaly Kuznetsov wrote:

quoted

quoted

  	preempt_notifier_inc();
+	kvm_init_pm_notifier(kvm);

You've probably thought it through and I didn't but wouldn't it be
easier to have one global pm_notifier call for KVM which would go
through the list of VMs instead of registering/deregistering a
pm_notifier call for every created/destroyed VM?

That raises questions on the locking, i.e. if we can we take the kvm_lock
safely from the notifier.

Right, I wanted to take the VM lock, rather than subsystem lock
(kvm_lock).